NetTalk Central

Author Topic: Redactor icons missing 11.31  (Read 2492 times)

peterH

  • Sr. Member
  • ****
  • Posts: 413
    • View Profile
Redactor icons missing 11.31
« on: March 30, 2020, 02:03:00 AM »
After recompiling an app in first 11.30 and then 11.31 some icons are now missing from a text control that uses redactor. I haven't changed anything in the program. The program was previously compiled with 11.some-low-number.

Do I need to do something or is it an oversight of some sort?

Before and after pics attached.

Peter
« Last Edit: March 30, 2020, 02:09:47 AM by peterH »

DonRidley

  • Don Ridley
  • Global Moderator
  • Hero Member
  • *****
  • Posts: 729
  • donaldridley2011@gmail.com
    • View Profile
    • Email
Re: Redactor icons missing 11.31
« Reply #1 on: March 30, 2020, 07:14:24 AM »
I think those are controlled by options in the Redactor script itself.  No icons involved per say.

Don
"Eliminate the impossible, whatever remains, however unlikely, must be the truth."

NetTalk 12.55
Clarion 11

peterH

  • Sr. Member
  • ****
  • Posts: 413
    • View Profile
Re: Redactor icons missing 11.31
« Reply #2 on: March 30, 2020, 08:38:51 AM »
Don,

Understood. And I've studied the RedactorInit methods in netweb.clw - but they are not easy to understand (at least for me  :) ).

Regardles, something has changed in the NT code resulting in the changed behavior.

Thanks
Peter

DonRidley

  • Don Ridley
  • Global Moderator
  • Hero Member
  • *****
  • Posts: 729
  • donaldridley2011@gmail.com
    • View Profile
    • Email
Re: Redactor icons missing 11.31
« Reply #3 on: March 30, 2020, 10:19:26 AM »
It's not in Clarion code.

It's in Redactor.js.  Around line 1569.

See attached text file.


« Last Edit: March 30, 2020, 10:21:26 AM by DonRidley »
"Eliminate the impossible, whatever remains, however unlikely, must be the truth."

NetTalk 12.55
Clarion 11

Bruce

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 11183
    • View Profile
Re: Redactor icons missing 11.31
« Reply #4 on: March 30, 2020, 07:24:56 PM »
Don is not wrong, but alas, also not completely right.

So yes, the (default) options are in the javascript file, but they are also set / overridden by the code in netweb.clw, NetWebServerWorkerBase.RedactorInit method.

Typically the JavaScript widgets have "options" - these are set when the widget is created. The copy in the JavaScript is used as a "default value" so the Clarion code does not have to set _all_ of them, only the ones that need it.

In this case the issue is somewhat more mechanical. The plugins themselves are not being loaded. I've fixed that for 11.33

Cheers
Bruce